Fix build error caused by upstream change from uglify-js (#251) #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This patch was originally written for `elm-jp/guide` by @negiboudu san
Closed
|
Hi, I remembered coming across this issue a while ago and several PR are in progress to solve it. I think this issue spans multiple repositories and has conflicting PR: Issues: PRs: I'm using terser, the main advantage is that it only requires one pass: I think there should be a discussion (maybe on discord?, maybe here?) to solve this reoccurring problem. |
|
I believe this is fixed by #258 as well. Just merged that one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch was originally written for
elm-jp/guideby @negiboudu san (ref)